Skip to content

[Test] Add Spring Cloud Gateway 4.3.3 and 5.0.0 to gateway scenario #787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Siman-hub wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[Test] Add Spring Cloud Gateway 4.3.3 and 5.0.0 to gateway scenario #787

Siman-hub wants to merge 3 commits into from
+2 −1

Conversation

@Siman-hub
Copy link

@Siman-hub Siman-hub commented Jan 30, 2026 •
edited
Loading

Summary

This PR adds Spring Cloud Gateway 4.3.3 and 5.0.0 to the gateway-4.x-scenario test matrix.

Compatibility Analysis

I verified source-level compatibility of NettyRoutingFilter in Gateway 4.3.3 and 5.0.0 against the existing v412x plugin.

  • Structure change: Gateway introduces getHttpClientMono, which is invoked by the main filter flow.
  • Safety check: In both versions, the implementation remains eager:
// org.springframework.cloud.gateway.filter.NettyRoutingFilter (v4.3.3)
protected Mono<HttpClient> getHttpClientMono(Route route, ServerWebExchange exchange) {
    return Mono.just(getHttpClient(route, exchange));
}
  • Conclusion: Since Mono.just is evaluated immediately on the calling thread, getHttpClient(...) (which SkyWalking instruments) is still executed synchronously during request handling. Execution order and context propagation remain unchanged, so the existing plugin continues to work as intended for both 4.3.3 and 5.0.0.

Verification

  • Validated source compatibility (NettyRoutingFilter structure).
  • Validated binary compatibility (Plugin compiles against 4.3.3 and 5.0.0).
  • Runtime verification delegated to CI (Local Windows environment limitations prevented full Docker scenario execution).

@Siman-hub Siman-hub changed the title [Test] Add Spring Cloud Gateway 4.3.3 to gateway-4.x-scenario [Test] Add Spring Cloud Gateway 4.3.3 and 5.0.0 to gateway scenario Jan 30, 2026
@Siman-hub
Copy link
Author

Siman-hub commented Jan 31, 2026

I’ve reverted the inclusion of Gateway 5.0.x from this PR.

Reason: the current gateway-4.x-scenario is based on a Spring Boot 3.x environment, and Gateway 5.0.x seems to require a newer Spring Boot / Spring Framework baseline, which caused dependency resolution conflicts in the existing scenario.

For now I’ll keep this PR focused on Gateway 4.3.3.

I’m happy to follow up separately for Gateway 5.x — please let me know if introducing a dedicated gateway-5.x-scenario sounds like the right approach.

@wu-sheng
Copy link
Member

wu-sheng commented Jan 31, 2026

I’ve reverted the inclusion of Gateway 5.0.x from this PR.

Reason: the current gateway-4.x-scenario is based on a Spring Boot 3.x environment, and Gateway 5.0.x seems to require a newer Spring Boot / Spring Framework baseline, which caused dependency resolution conflicts in the existing scenario.

For now I’ll keep this PR focused on Gateway 4.3.3.

I’m happy to follow up separately for Gateway 5.x — please let me know if introducing a dedicated gateway-5.x-scenario sounds like the right approach.

It depends whether 5.x requires a new plugin implementation. If not, you could just add a new test scenario for 5.x, copy most of codes from here, and change Spring version to newer.

@Siman-hub
Copy link
Author

Siman-hub commented Jan 31, 2026

I’ve reverted the inclusion of Gateway 5.0.x from this PR.
Reason: the current gateway-4.x-scenario is based on a Spring Boot 3.x environment, and Gateway 5.0.x seems to require a newer Spring Boot / Spring Framework baseline, which caused dependency resolution conflicts in the existing scenario.
For now I’ll keep this PR focused on Gateway 4.3.3.
I’m happy to follow up separately for Gateway 5.x — please let me know if introducing a dedicated gateway-5.x-scenario sounds like the right approach.

It depends whether 5.x requires a new plugin implementation. If not, you could just add a new test scenario for 5.x, copy most of codes from here, and change Spring version to newer.

Thanks for the guidance!

I checked NettyRoutingFilter in Gateway 5.x and the main interception point (getHttpClient) still looks structurally similar to 4.x, so my current assumption is that the existing plugin might continue to work.

I’ll follow your suggestion and add a separate gateway-5.x-scenario (copied from 4.x with upgraded Spring/Gateway versions) to validate runtime behavior. If I hit any incompatibilities requiring plugin changes, I’ll report back.

@wu-sheng
Copy link
Member

wu-sheng commented Jan 31, 2026

If this 4.x test passes, please add plugin docs and change log to indicate this new supported version.

@wu-sheng
Copy link
Member

wu-sheng commented Jan 31, 2026

It seems 4.3.3 doesn't work.

@Siman-hub
Copy link
Author

Siman-hub commented Jan 31, 2026

Thanks — I’m reproducing the failing gateway-4.x-scenario-jdk17 locally now to pinpoint the exact runtime failure (startup vs assertion).
I’ve completed a full build successfully and am running the scenario to capture the concrete error.
I’ll report back once I have the root cause so we can decide whether this needs scenario dependency updates or plugin adjustments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

plugin

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Siman-hub @wu-sheng